RepoCleaner : Naming conventions and warnings #2477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barthelemy
changed the title
- fix warnings
- fix warnings - organize imports
Barthelemy
force-pushed
the
naming-conventions-and-warnings2
branch
from
526a990 to
4a13d48
Compare
knopers8
reviewed
Jan 9, 2025
| self.assertEqual(stats["deleted"], 0) | ||
| self.assertEqual(stats["preserved"], 18) | ||
| self.assertEqual(stats["updated"], 0) | ||
| # def test_5_runs(self): |
Collaborator
There was a problem hiding this comment.
is it intentionally commented out?
Collaborator
Author
There was a problem hiding this comment.
yes it is, and yes a comment should explain why. I will add it.
The reason is that running test_5_runs makes a lot of requests to the ccdb-test. If you run it along the rest, you will reach a limit and get requests denied by the server (rate limiting I guess). If you run it by itself it is fine. If you run the others without it, it is fine.
Not nice, I know. Possible solutions : sleep, use a mock (already ruled out), spawn a local database.
Collaborator
Author
|
@knopers8 @justonedev1 could one of you review and approve please ? |
knopers8
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.